GH-145378: Use PyREPL as the default input console for pdb#145379
Open
gaogaotiantian wants to merge 5 commits intopython:mainfrom
Open
GH-145378: Use PyREPL as the default input console for pdb#145379gaogaotiantian wants to merge 5 commits intopython:mainfrom
gaogaotiantian wants to merge 5 commits intopython:mainfrom
Conversation
Member
Author
|
@pablogsal and @ambv as the original author for the new interactive shell. Could you take a look when you have some time, thanks! |
tanloong
reviewed
Mar 6, 2026
| def readline(self): | ||
| from _pyrepl.simple_interact import _more_lines | ||
|
|
||
| def more_lines(text): |
Contributor
There was a problem hiding this comment.
Super excited about PyREPL into pdb!
Just wanted to flag a small issue I ran into on Windows: pressing Ctrl+Z+Enter does not quit pdb, instead it throws a SyntaxError: invalild non-printable character U+001A.
I did a quick experiment, if we add a ^Z check in more_lines function, the issue seems to be resolved. Not sure if this is the most elegant fix, but in case it helps.
def more_lines(text):
if text.rstrip().endswith("\x1a"):
raise EOFError
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.